Re: [Qemu-devel] [PATCH 16/31] seccomp: Clean up error reporting in parse_sandbox()

2018-10-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Oct 8, 2018 at 9:50 PM Markus Armbruster wrote: >> >> Calling error_report() in a function that takes an Error ** argument >> is suspicious. parse_sandbox() does that, and then fails without >> setting an error. Its caller main(), via

Re: [Qemu-devel] [PATCH 16/31] seccomp: Clean up error reporting in parse_sandbox()

2018-10-10 Thread Eduardo Otubo
On 08/10/2018 - 19:31:10, Markus Armbruster wrote: > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_sandbox() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean it up anyway.

Re: [Qemu-devel] [PATCH 16/31] seccomp: Clean up error reporting in parse_sandbox()

2018-10-09 Thread Marc-André Lureau
Hi On Mon, Oct 8, 2018 at 9:50 PM Markus Armbruster wrote: > > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_sandbox() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean it

[Qemu-devel] [PATCH 16/31] seccomp: Clean up error reporting in parse_sandbox()

2018-10-08 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. parse_sandbox() does that, and then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway. Cc: Eduardo Otubo Signed-off-by: Markus Armbruster ---