Re: [Qemu-devel] [PATCH 17/31] vl: Clean up error reporting in parse_add_fd()

2018-10-09 Thread Marc-André Lureau
Hi On Mon, Oct 8, 2018 at 9:44 PM Markus Armbruster wrote: > > Calling error_report() in a function that takes an Error ** argument > is suspicious. parse_add_fd() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean it u

[Qemu-devel] [PATCH 17/31] vl: Clean up error reporting in parse_add_fd()

2018-10-08 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. parse_add_fd() does that, and then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway. Also change call of cleanup_add_fd(), which can't fail, for