Re: [Qemu-devel] [PATCH 17/32] qmp: Don't let malformed in-band commands jump the queue

2018-07-03 Thread Markus Armbruster
Eric Blake writes: > On 07/02/2018 11:22 AM, Markus Armbruster wrote: >> handle_qmp_command() reports certain errors right away. This is wrong >> when OOB is enabled, because the errors can "jump the queue" then, as >> the previous commit demonstrates. >> >> To fix, we need to delay errors

Re: [Qemu-devel] [PATCH 17/32] qmp: Don't let malformed in-band commands jump the queue

2018-07-02 Thread Eric Blake
On 07/02/2018 11:22 AM, Markus Armbruster wrote: handle_qmp_command() reports certain errors right away. This is wrong when OOB is enabled, because the errors can "jump the queue" then, as the previous commit demonstrates. To fix, we need to delay errors until dispatch. Do that for semantic

[Qemu-devel] [PATCH 17/32] qmp: Don't let malformed in-band commands jump the queue

2018-07-02 Thread Markus Armbruster
handle_qmp_command() reports certain errors right away. This is wrong when OOB is enabled, because the errors can "jump the queue" then, as the previous commit demonstrates. To fix, we need to delay errors until dispatch. Do that for semantic errors, mostly by reverting ill-advised parts of