Re: [Qemu-devel] [PATCH 17/36] qtest: Avoid dynamic JSON in ahci-test

2016-11-30 Thread Eric Blake
On 11/30/2016 03:02 PM, John Snow wrote: > > > On 11/30/2016 02:44 PM, Eric Blake wrote: >> As argued elsewhere, it's less code to maintain if we convert >> from a dynamic string passed to qobject_from_jsonv() to instead >> use a hand-built QDict. >> >> Rather than build up a QDict by manual

Re: [Qemu-devel] [PATCH 17/36] qtest: Avoid dynamic JSON in ahci-test

2016-11-30 Thread John Snow
On 11/30/2016 02:44 PM, Eric Blake wrote: > As argued elsewhere, it's less code to maintain if we convert > from a dynamic string passed to qobject_from_jsonv() to instead > use a hand-built QDict. > > Rather than build up a QDict by manual qdict_put*() calls, we > can let QAPI do the work for

[Qemu-devel] [PATCH 17/36] qtest: Avoid dynamic JSON in ahci-test

2016-11-30 Thread Eric Blake
As argued elsewhere, it's less code to maintain if we convert from a dynamic string passed to qobject_from_jsonv() to instead use a hand-built QDict. Rather than build up a QDict by manual qdict_put*() calls, we can let QAPI do the work for us. The result is more lines of code to initialize the