Re: [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-04 Thread Richard Henderson
On 07/04/2017 01:12 AM, Paolo Bonzini wrote: From: Yang Zhong Split the cpu_set_mxcsr() and make cpu_set_fpuc() inline with specific tcg code. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- v2: renamed

[Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-04 Thread Paolo Bonzini
From: Yang Zhong Split the cpu_set_mxcsr() and make cpu_set_fpuc() inline with specific tcg code. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- v2: renamed tcg_update_mxcsr [Richard], added missing

Re: [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-04 Thread Paolo Bonzini
On 03/07/2017 22:14, Richard Henderson wrote: > On 07/03/2017 09:34 AM, Paolo Bonzini wrote: >> +static inline void cpu_set_mxcsr(CPUX86State *env, uint32_t mxcsr) >> +{ >> +env->mxcsr = mxcsr; >> +if (tcg_enabled()) { >> +tcg_update_mxcsr(env); > > I'd prefer

Re: [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-03 Thread Richard Henderson
On 07/03/2017 09:34 AM, Paolo Bonzini wrote: +static inline void cpu_set_mxcsr(CPUX86State *env, uint32_t mxcsr) +{ +env->mxcsr = mxcsr; +if (tcg_enabled()) { +tcg_update_mxcsr(env); I'd prefer update_mxcsr_status for this new name. +} +} + +static inline void

[Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

2017-07-03 Thread Paolo Bonzini
From: Yang Zhong Split the cpu_set_mxcsr() and make cpu_set_fpuc() inline with specific tcg code. Signed-off-by: Yang Zhong Signed-off-by: Paolo Bonzini --- target/i386/cpu.h| 18 --