Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-27 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 24.02.2012 12:37, schrieb Federico Simoncelli: [...] diff --git a/blockdev.c b/blockdev.c index 2c132a3..1df2542 100644 --- a/blockdev.c +++ b/blockdev.c [...] +void qmp_blockdev_migrate(const char *device, BlockMigrateOp mode, +

[Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- block/blkmirror.c |2 +- blockdev.c| 109 +++-- hmp-commands.hx | 36 + hmp.c | 30 ++ hmp.h |2 + qapi-schema.json

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Kevin Wolf
Am 24.02.2012 12:37, schrieb Federico Simoncelli: Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- block/blkmirror.c |2 +- blockdev.c| 109 +++-- hmp-commands.hx | 36 + hmp.c | 30

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Federico Simoncelli
- Original Message - From: Kevin Wolf kw...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, Marcelo Tosatti mtosa...@redhat.com, lcapitul...@redhat.com, Paolo Bonzini pbonz...@redhat.com, Markus Armbruster arm...@redhat.com Sent: Friday, February

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 01:03 PM, Kevin Wolf wrote: + loop: +if (!(i sizeof(filename) - 2)) { +error_set(errp, QERR_INVALID_PARAMETER_VALUE, + new-image-file, shorter filename); +return; +} + +if

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 13:03:08 +0100 Kevin Wolf kw...@redhat.com wrote: static void eject_device(BlockDriverState *bs, int force, Error **errp) { if (bdrv_in_use(bs)) { diff --git a/hmp-commands.hx b/hmp-commands.hx index 573b823..ccb1f62 100644 --- a/hmp-commands.hx +++