Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Paolo Bonzini
Il 22/08/2014 11:26, Peter Lieven ha scritto: Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index ed883c3..131357c 100644 --- a/block/iscsi.c +++

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:10, Peter Lieven ha scritto: On 25.08.2014 12:37, Paolo Bonzini wrote: Il 22/08/2014 11:26, Peter Lieven ha scritto: Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:26, Peter Lieven ha scritto: Hmm, good question. If so, the patch is correct with error_report. I thought a failure in iscsi_open would be less surprising. The question then is, do we need an option to disable allocationmap queries? We have cache=none... Doh, right.

[Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-22 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index ed883c3..131357c 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -325,6 +325,19 @@ static bool