Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Eric Blake
On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by:

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Peter Krempa
On 05/31/13 14:36, Eric Blake wrote: On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Gerd Hoffmann
Hi, Without this patch the returned message for query-chardev is: { return: [ { filename: pty:/dev/pts/8, label: charserial0 }, { filename: unix:/var/lib/libvirt/qemu/qemu-git.monitor,server, label:

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-31 Thread Peter Krempa
On 05/31/13 15:21, Gerd Hoffmann wrote: Hi, Hi, Please double-check. Current master (87d23f78aa79b72da022afda358bbc8a8509ca70 to be exact) works just fine for me. libvirt works, including a serial line redirected to pty, and 'info chardev' looks sane too. sorry for the fuzz. :/

[Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
On 05/28/13 08:34, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd

[Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

2013-05-28 Thread Gerd Hoffmann
Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |