Re: [Qemu-devel] [PATCH 2/2] migration: to_dst_file at that point is NULL

2017-04-26 Thread Peter Xu
On Tue, Apr 25, 2017 at 12:17:58PM +0200, Juan Quintela wrote: > We have just arrived as: > > migration.c: qemu_migrate() > > s = migrate_init() <- puts it to NULL > > {tcp,unix}_start_outgoing_migration -> > socket_outgoing_migration > migration_channel_connect() >

Re: [Qemu-devel] [PATCH 2/2] migration: to_dst_file at that point is NULL

2017-04-25 Thread Daniel P. Berrange
On Tue, Apr 25, 2017 at 12:17:58PM +0200, Juan Quintela wrote: > We have just arrived as: > > migration.c: qemu_migrate() > > s = migrate_init() <- puts it to NULL > > {tcp,unix}_start_outgoing_migration -> > socket_outgoing_migration > migration_channel_connect() >

Re: [Qemu-devel] [PATCH 2/2] migration: to_dst_file at that point is NULL

2017-04-25 Thread Laurent Vivier
On 25/04/2017 14:59, Juan Quintela wrote: > Laurent Vivier wrote: >> On 25/04/2017 12:17, Juan Quintela wrote: >>> We have just arrived as: >>> >>> migration.c: qemu_migrate() >>> >>> s = migrate_init() <- puts it to NULL >>> >>>

Re: [Qemu-devel] [PATCH 2/2] migration: to_dst_file at that point is NULL

2017-04-25 Thread Juan Quintela
Laurent Vivier wrote: > On 25/04/2017 12:17, Juan Quintela wrote: >> We have just arrived as: >> >> migration.c: qemu_migrate() >> >> s = migrate_init() <- puts it to NULL >> >> {tcp,unix}_start_outgoing_migration -> >> socket_outgoing_migration >>

Re: [Qemu-devel] [PATCH 2/2] migration: to_dst_file at that point is NULL

2017-04-25 Thread Laurent Vivier
On 25/04/2017 12:17, Juan Quintela wrote: > We have just arrived as: > > migration.c: qemu_migrate() > > s = migrate_init() <- puts it to NULL > > {tcp,unix}_start_outgoing_migration -> > socket_outgoing_migration > migration_channel_connect() > sets

[Qemu-devel] [PATCH 2/2] migration: to_dst_file at that point is NULL

2017-04-25 Thread Juan Quintela
We have just arrived as: migration.c: qemu_migrate() s = migrate_init() <- puts it to NULL {tcp,unix}_start_outgoing_migration -> socket_outgoing_migration migration_channel_connect() sets to_dst_file if tls is enabled, we do another round through