[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-05 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 55 qga/qapi-schema.json | 26 + 2 files changed, 81 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Lei Li
On 03/02/2013 01:38 AM, Eric Blake wrote: On 03/01/2013 02:33 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 55 qga/qapi-schema.json | 27 ++ 2 files changed, 82

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 54 qga/qapi-schema.json | 27 ++ 2 files changed, 81 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread mdroth
On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 54 qga/qapi-schema.json | 27 ++ 2 files changed, 81 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Eric Blake
On 03/04/2013 02:16 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 54 qga/qapi-schema.json | 27 ++ 2 files changed, 81 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Eric Blake
On 03/04/2013 11:16 AM, mdroth wrote: On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 54 qga/qapi-schema.json | 27 ++ 2 files

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-01 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 55 qga/qapi-schema.json | 27 ++ 2 files changed, 82 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-01 Thread Eric Blake
On 03/01/2013 02:33 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 55 qga/qapi-schema.json | 27 ++ 2 files changed, 82 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-01 Thread Eric Blake
On 03/01/2013 10:38 AM, Eric Blake wrote: +error_setg_errno(errp, errno, Invalid time %ld for overflow, + time_ns); That wording sounds awkward. Worse, errno is NOT set to anything sane, so you do NOT want error_setg_errno. And %ld is wrong for int64_t on

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-29 Thread Lei Li
On 01/29/2013 04:45 AM, Eric Blake wrote: On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-28 Thread Eric Blake
On 01/27/2013 11:14 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-01-27 Thread Lei Li
Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-posix.c | 76 ++ qga/qapi-schema.json | 42 +++ 2 files changed, 118 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c