Re: [Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-11 Thread Fam Zheng
On Thu, 08/07 16:25, Kevin Wolf wrote: Am 05.08.2014 um 11:11 hat Fam Zheng geschrieben: Replace init/destroy with realize/unrealize in SCSIDeviceClass, which has errp as a parameter. So all the implementations now uses error_setg instead of error_report for reporting error. Also in

Re: [Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-07 Thread Kevin Wolf
Am 05.08.2014 um 11:11 hat Fam Zheng geschrieben: Replace init/destroy with realize/unrealize in SCSIDeviceClass, which has errp as a parameter. So all the implementations now uses error_setg instead of error_report for reporting error. Also in lsi53c895a, report the error when initializing

[Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-05 Thread Fam Zheng
Replace init/destroy with realize/unrealize in SCSIDeviceClass, which has errp as a parameter. So all the implementations now uses error_setg instead of error_report for reporting error. Also in lsi53c895a, report the error when initializing the if=scsi devices, before dropping it, because the

Re: [Qemu-devel] [PATCH 2/2] scsi-bus: Convert DeviceClass init to realize

2014-08-05 Thread Fam Zheng
On Tue, 08/05 17:11, Fam Zheng wrote: Replace init/destroy with realize/unrealize in SCSIDeviceClass, which has errp as a parameter. So all the implementations now uses s/uses/use/ error_setg instead of error_report for reporting error. Also in lsi53c895a, report the error when