Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-08-12 Thread Eric Blake
On 7/29/19 6:08 AM, Kevin Wolf wrote: >> On a different topic, how much of this work overlaps with the nbdkit ssh >> plugin? Should we be duplicating efforts with both projects supporting >> ssh natively, or is it worth considering getting qemu out of the ssh >> business and instead connecting to

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-08-12 Thread Max Reitz
On 29.07.19 13:08, Kevin Wolf wrote: > Am 26.07.2019 um 16:24 hat Eric Blake geschrieben: >> On 7/26/19 9:09 AM, Pino Toscano wrote: >>> Add a 'private-key' option which represents the path of a private key >>> to use for authentication, and 'private-key-secret' as the name of an >>> object with

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Markus Armbruster
Pino Toscano writes: > On Monday, 29 July 2019 12:57:40 CEST Markus Armbruster wrote: >> Pino Toscano writes: >> >> > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: >> >> On 7/26/19 9:09 AM, Pino Toscano wrote: >> >> > Add a 'private-key' option which represents the path of a private

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Pino Toscano
On Monday, 29 July 2019 12:57:40 CEST Markus Armbruster wrote: > Pino Toscano writes: > > > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: > >> On 7/26/19 9:09 AM, Pino Toscano wrote: > >> > Add a 'private-key' option which represents the path of a private key > >> > to use for

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Kevin Wolf
Am 26.07.2019 um 16:24 hat Eric Blake geschrieben: > On 7/26/19 9:09 AM, Pino Toscano wrote: > > Add a 'private-key' option which represents the path of a private key > > to use for authentication, and 'private-key-secret' as the name of an > > object with its passphrase. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Markus Armbruster
Pino Toscano writes: > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: >> On 7/26/19 9:09 AM, Pino Toscano wrote: >> > Add a 'private-key' option which represents the path of a private key >> > to use for authentication, and 'private-key-secret' as the name of an >> > object with its

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-29 Thread Pino Toscano
On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote: > On 7/26/19 9:09 AM, Pino Toscano wrote: > > Add a 'private-key' option which represents the path of a private key > > to use for authentication, and 'private-key-secret' as the name of an > > object with its passphrase. > > > >

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-26 Thread Richard W.M. Jones
On Fri, Jul 26, 2019 at 09:24:34AM -0500, Eric Blake wrote: > On a different topic, how much of this work overlaps with the nbdkit ssh > plugin? Should we be duplicating efforts with both projects supporting > ssh natively, or is it worth considering getting qemu out of the ssh > business and

Re: [Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-26 Thread Eric Blake
On 7/26/19 9:09 AM, Pino Toscano wrote: > Add a 'private-key' option which represents the path of a private key > to use for authentication, and 'private-key-secret' as the name of an > object with its passphrase. > > Signed-off-by: Pino Toscano > +++ b/qapi/block-core.json > @@ -3226,6

[Qemu-devel] [PATCH 2/2] ssh: implement private key authentication

2019-07-26 Thread Pino Toscano
Add a 'private-key' option which represents the path of a private key to use for authentication, and 'private-key-secret' as the name of an object with its passphrase. Signed-off-by: Pino Toscano --- block/ssh.c | 98 block/trace-events