Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-22 Thread Peter Crosthwaite
On Sat, Jul 21, 2012 at 12:56 AM, jagan 402ja...@gmail.com wrote: Thanks for your info, In fact I was thinking about to use drive_get(IF_PFLASH, 0, 0) for first and drive_get(IF_PFLASH, 0, 1) also. But the point I was still uncover is even I was using drive_get(IF_PFLASH, 0, 0) on both

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
I think I understand the situation, like when I called pflash_cfi01_register, it verifies BlockDriverState is 0. Was my understanding correct? If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to drive_get_next(IF_PFLASH) on second flash access by keeping drive_get(IF_PFLASH, 0, 0

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
And one more point is when I tried drive_get(IF_PFLASH, 0, 0) and then drive_get_next(IF_PFLASH) individually on second flash. I didn't observe any issue on bdrv_attach_dev_nofail, as it seems to be failed on second case if we re-access the flash. Code snippet: -- +

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread Igor Mitsyanko
On 07/20/2012 05:30 PM, jagan wrote: I think I understand the situation, like when I called pflash_cfi01_register, it verifies BlockDriverState is 0. Was my understanding correct? If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to drive_get_next(IF_PFLASH) on second flash

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
Thanks for your info, In fact I was thinking about to use drive_get(IF_PFLASH, 0, 0) for first and drive_get(IF_PFLASH, 0, 1) also. But the point I was still uncover is even I was using drive_get(IF_PFLASH, 0, 0) on both the flashes, If I tested through u-boot I was able to detect two flashes

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-19 Thread Igor Mitsyanko
On 07/19/2012 01:16 PM, jagan wrote: Yes, I have used same drive_get(IF_PFLASH, 0, 0) with two flashes. As these flashes are two different banks with individual bases address, I used the same. Was there any block allocation problem with this..will you please elaborate. I couldn't understand

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-19 Thread Peter Crosthwaite
On Thu, Jul 19, 2012 at 7:16 PM, jagan 402ja...@gmail.com wrote: Yes, I have used same drive_get(IF_PFLASH, 0, 0) with two flashes. As these flashes are two different banks with individual bases address, I used the same. Was there any block allocation problem with this..will you please

[Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-18 Thread 402jagan
From: Jagan 402ja...@gmail.com This patch adds support for NOR1 flash (Bank #2) on vexpress-a9 platform. It is 64MB CFI01 compliant flash. Tested on stable u-boot version through Linux. Signed-off-by: Jagan 402ja...@gmail.com --- hw/vexpress.c | 10 +- 1 files changed, 9

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-18 Thread Peter Crosthwaite
On Thu, Jul 19, 2012 at 5:03 AM, 402ja...@gmail.com wrote: From: Jagan 402ja...@gmail.com This patch adds support for NOR1 flash (Bank #2) on vexpress-a9 platform. It is 64MB CFI01 compliant flash. Tested on stable u-boot version through Linux. Signed-off-by: Jagan 402ja...@gmail.com ---