Re: [Qemu-devel] [PATCH 2/3] Tracepoint, buffer monitor framework

2010-05-25 Thread Stefan Hajnoczi
+#define DEFINE_TRACE(name, tproto, tassign, tprint)\ + void trace_##name(tproto) \ + { \ + unsigned int hash;\ + char tpname[] =

Re: [Qemu-devel] [PATCH 2/3] Tracepoint, buffer monitor framework

2010-05-25 Thread Prerna Saxena
Hi Stefan, Thanks for having a look. As I'd mentioned, this patchset is *work in progress*, which explains the dummy comments and coding style violations at places :) I was merely sharing a draft of what my approach is -- so that we can work together on how much of it can add to the trace

Re: [Qemu-devel] [PATCH 2/3] Tracepoint, buffer monitor framework

2010-05-25 Thread Stefan Hajnoczi
On Tue, May 25, 2010 at 7:20 PM, Prerna Saxena pre...@linux.vnet.ibm.com wrote: Some added lines of code use tabs for indentation, 4 space indentation should be used. +struct tracepoint { +       char *name;                     /* Tracepoint name */ +       uint8_t  trace_id;              

[Qemu-devel] [PATCH 2/3] Tracepoint, buffer monitor framework

2010-05-24 Thread Prerna Saxena
Patch that implements tracepoint framework + trace buffer + monitor support. tracing can be enabled at compile time using --enable-trace switch, which compiles tracing support(all of these). Monitor commands introduced : 1. info trace : to see contents of trace buffer. 2. info tracepoints :