[Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-06-07 Thread Christoph Hellwig
We don't have an equivalent to mmap in the qemu block API, so read and write the bitmap directly. At least in the dumb implementation added in this patch this is a lot less efficient, but it means cow can also work on windows, and over nbd or curl. And it fixes qemu-iotests testcase 012 which

Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-10 Thread Kevin Wolf
Am 07.05.2010 17:17, schrieb Christoph Hellwig: We don't have an equivalent to mmap in the qemu block API, so read and write the bitmap directly. At least in the dumb implementation added in this patch this is a lot less efficient, but it means cow can also work on windows, and over nbd or

Re: [Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-10 Thread Christoph Hellwig
On Mon, May 10, 2010 at 11:41:15AM +0200, Kevin Wolf wrote: For one, there is a typo in the variable name, and also this is a void function which shouldn't return anything. The caller still seems to use the return value. Should probably stay an int function. Yes, this was missing a quilt

[Qemu-devel] [PATCH 2/3] cow: stop using mmap

2010-05-07 Thread Christoph Hellwig
We don't have an equivalent to mmap in the qemu block API, so read and write the bitmap directly. At least in the dumb implementation added in this patch this is a lot less efficient, but it means cow can also work on windows, and over nbd or curl. And it fixes qemu-iotests testcase 012 which