Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 13:42, Peter Maydell wrote: On 30 October 2018 at 11:28, Philippe Mathieu-Daudé wrote: On 30/10/18 10:36, Peter Maydell wrote: On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 +

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Peter Maydell
On 30 October 2018 at 11:28, Philippe Mathieu-Daudé wrote: > On 30/10/18 10:36, Peter Maydell wrote: >> >> On 29 October 2018 at 23:20, Philippe Mathieu-Daudé >> wrote: >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> MAINTAINERS| 1 + >>> hw/arm/xilinx_zynq.c | 18

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 0:20, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/arm/xilinx_zynq.c | 18 ++ hw/dma/pl330.c | 2 +- include/hw/dma/pl330.h | 41 + 4 files changed,

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 10:36, Peter Maydell wrote: On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/arm/xilinx_zynq.c | 18 ++ hw/dma/pl330.c | 2 +- include/hw/dma/pl330.h | 41

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Peter Maydell
On 29 October 2018 at 23:20, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS| 1 + > hw/arm/xilinx_zynq.c | 18 ++ > hw/dma/pl330.c | 2 +- > include/hw/dma/pl330.h | 41 + >

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Philippe Mathieu-Daudé
On 30/10/18 9:18, Richard Henderson wrote: On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq) +{ +SysBusDevice *busdev; +DeviceState *dev; + +dev = qdev_create(NULL, TYPE_PL330); +qdev_prop_set_uint8(dev,

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-30 Thread Richard Henderson
On 10/29/18 11:20 PM, Philippe Mathieu-Daudé wrote: > +static inline void pl330_init(uint32_t base, qemu_irq irq, int nreq) > +{ > +SysBusDevice *busdev; > +DeviceState *dev; > + > +dev = qdev_create(NULL, TYPE_PL330); > +qdev_prop_set_uint8(dev, "num_chnls", 8); > +

Re: [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-29 Thread Alistair Francis
On Mon, Oct 29, 2018 at 4:24 PM Philippe Mathieu-Daudé wrote: > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Alistair > --- > MAINTAINERS| 1 + > hw/arm/xilinx_zynq.c | 18 ++ > hw/dma/pl330.c | 2 +- > include/hw/dma/pl330.h

[Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c

2018-10-29 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/arm/xilinx_zynq.c | 18 ++ hw/dma/pl330.c | 2 +- include/hw/dma/pl330.h | 41 + 4 files changed, 45 insertions(+), 17 deletions(-) create mode 100644