Re: [Qemu-devel] [PATCH 2/3] iothread: export iothread_stop()

2017-09-24 Thread Peter Xu
On Fri, Sep 22, 2017 at 09:06:26PM +0800, Fam Zheng wrote: > On Fri, 09/22 16:56, Peter Xu wrote: > > So that internal iothread users can explicitly stop one iothread without > > destroying it. > > > > Since at it, fix iothread_stop() to allow re-entrance. Before this > > I don't think there is

Re: [Qemu-devel] [PATCH 2/3] iothread: export iothread_stop()

2017-09-22 Thread Fam Zheng
On Fri, 09/22 16:56, Peter Xu wrote: > So that internal iothread users can explicitly stop one iothread without > destroying it. > > Since at it, fix iothread_stop() to allow re-entrance. Before this I don't think there is any re-entrace here. Maybe you mean s/re-entrance/calling multiple

[Qemu-devel] [PATCH 2/3] iothread: export iothread_stop()

2017-09-22 Thread Peter Xu
So that internal iothread users can explicitly stop one iothread without destroying it. Since at it, fix iothread_stop() to allow re-entrance. Before this patch we may call iothread_stop() twice on single iothread, while that may not be correct since qemu_thread_join() is not allowed to run