Re: [Qemu-devel] [PATCH 2/3] spapr/pci: Free MSIs during reset

2019-07-28 Thread David Gibson
On Fri, Jul 26, 2019 at 04:44:44PM +0200, Greg Kurz wrote: > When the machine is reset, the MSI bitmap is cleared but the allocated > MSIs are not freed. Some operating systems, such as AIX, can detect the > previous configuration and assert. > > Empty the MSI cache, this performs the needed clean

Re: [Qemu-devel] [PATCH 2/3] spapr/pci: Free MSIs during reset

2019-07-26 Thread Greg Kurz
On Fri, 26 Jul 2019 18:17:57 +0200 Philippe Mathieu-Daudé wrote: > Cc'ing qemu-stable@ > This patch relies on the previous one, otherwise g_hash_table_remove_all() will just g_free() the spapr_pci_msi structures, but it will not tear down the MSIs in the interrupt controller. Also, this bug is

Re: [Qemu-devel] [PATCH 2/3] spapr/pci: Free MSIs during reset

2019-07-26 Thread Philippe Mathieu-Daudé
Cc'ing qemu-stable@ On 7/26/19 4:44 PM, Greg Kurz wrote: > When the machine is reset, the MSI bitmap is cleared but the allocated > MSIs are not freed. Some operating systems, such as AIX, can detect the > previous configuration and assert. > > Empty the MSI cache, this performs the needed cleanu

Re: [Qemu-devel] [PATCH 2/3] spapr/pci: Free MSIs during reset

2019-07-26 Thread Cédric Le Goater
On 26/07/2019 16:44, Greg Kurz wrote: > When the machine is reset, the MSI bitmap is cleared but the allocated > MSIs are not freed. Some operating systems, such as AIX, can detect the > previous configuration and assert. > > Empty the MSI cache, this performs the needed cleanup. This is fixing t

[Qemu-devel] [PATCH 2/3] spapr/pci: Free MSIs during reset

2019-07-26 Thread Greg Kurz
When the machine is reset, the MSI bitmap is cleared but the allocated MSIs are not freed. Some operating systems, such as AIX, can detect the previous configuration and assert. Empty the MSI cache, this performs the needed cleanup. Signed-off-by: Greg Kurz --- hw/ppc/spapr_pci.c |2 ++ 1 f