[Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features

2012-03-06 Thread Paolo Bonzini
It is not a problem if the destination does not have VIRTIO_BALLOON_F_MUST_TELL_HOST. In that case, the guest will simply do useless virtqueue traffic, but the destination does not have a problem. (In fact, it _is_ a problem if the destination has VIRTIO_BALLOON_F_MUST_TELL_HOST but the source

Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features

2012-03-06 Thread Michael S. Tsirkin
On Tue, Mar 06, 2012 at 01:22:06PM +0100, Paolo Bonzini wrote: It is not a problem if the destination does not have VIRTIO_BALLOON_F_MUST_TELL_HOST. In that case, the guest will simply do useless virtqueue traffic, but the destination does not have a problem. (In fact, it _is_ a problem if

Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features

2012-03-06 Thread Paolo Bonzini
Il 06/03/2012 15:55, Michael S. Tsirkin ha scritto: It is not a problem if the destination does not have VIRTIO_BALLOON_F_MUST_TELL_HOST. In that case, the guest will simply do useless virtqueue traffic, but the destination does not have a problem. (In fact, it _is_ a problem if the

Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features

2012-03-06 Thread Michael S. Tsirkin
On Tue, Mar 06, 2012 at 03:59:53PM +0100, Paolo Bonzini wrote: Il 06/03/2012 15:55, Michael S. Tsirkin ha scritto: It is not a problem if the destination does not have VIRTIO_BALLOON_F_MUST_TELL_HOST. In that case, the guest will simply do useless virtqueue traffic, but the destination

Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features

2012-03-06 Thread Paolo Bonzini
Il 06/03/2012 16:08, Michael S. Tsirkin ha scritto: Can't we just add a flag to control this feature? I think the sane thing here would be to remove it from the spec. I guess we could but what does it buy us? Not having a broken spec. :) The pedantically correct thing to do would be