Re: [Qemu-devel] [PATCH 2/4] s390x: remove duplicate definitions of DIAG 501

2014-05-30 Thread Alexander Graf
On 12.05.14 14:15, Jens Freimann wrote: From: David Hildenbrand d...@linux.vnet.ibm.com When restoring the previously saved instruction in kvm_arch_remove_sw_breakpoint(), we only restored one byte. Let's use the sizeof() operator to make sure we restore the entire instruction. While we are

Re: [Qemu-devel] [PATCH 2/4] s390x: remove duplicate definitions of DIAG 501

2014-05-30 Thread Christian Borntraeger
On 30/05/14 10:21, Alexander Graf wrote: On 12.05.14 14:15, Jens Freimann wrote: From: David Hildenbrand d...@linux.vnet.ibm.com When restoring the previously saved instruction in kvm_arch_remove_sw_breakpoint(), we only restored one byte. Let's use the sizeof() operator to make sure we

[Qemu-devel] [PATCH 2/4] s390x: remove duplicate definitions of DIAG 501

2014-05-12 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com When restoring the previously saved instruction in kvm_arch_remove_sw_breakpoint(), we only restored one byte. Let's use the sizeof() operator to make sure we restore the entire instruction. While we are at it, let's remove the duplicate

[Qemu-devel] [PATCH 2/4] s390x: remove duplicate definitions of DIAG 501

2014-05-12 Thread Jens Freimann
From: David Hildenbrand d...@linux.vnet.ibm.com When restoring the previously saved instruction in kvm_arch_remove_sw_breakpoint(), we only restored one byte. Let's use the sizeof() operator to make sure we restore the entire instruction. While we are at it, let's remove the duplicate