Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Juan Quintela writes: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela [...] > diff --git a/include/migration/block.h b/include/migration/block.h > index 41a1ac8..5225af9

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

On 05/18/2017 06:18 AM, Juan Quintela wrote: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela > > --- > Reviewed-by: Eric Blake -- Eric Blake, Principal Software

[Qemu-devel] [PATCH 2/5] migration: Create block capability

Create one capability for block migration and one parameter for incremental block migration. Signed-off-by: Juan Quintela --- - address all Markus comments - use Markus and Eric text descriptions - change logic another time - improve text messages --- hmp.c

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Eric Blake wrote: > On 05/17/2017 10:38 AM, Juan Quintela wrote: >> Create one capability for block migration and one parameter for >> incremental block migration. >> >> Signed-off-by: Juan Quintela >> >> --- >> >> @@ -1207,6 +1242,26 @@ void

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

On 05/17/2017 10:38 AM, Juan Quintela wrote: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela > > --- > > @@ -1207,6 +1242,26 @@ void qmp_migrate(const char *uri, bool has_blk, bool > blk, >

[Qemu-devel] [PATCH 2/5] migration: Create block capability

Create one capability for block migration and one parameter for incremental block migration. Signed-off-by: Juan Quintela --- - address all Markus comments - use Markus and Eric text descriptions Signed-off-by: Juan Quintela --- hmp.c

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Eric Blake wrote: > On 05/16/2017 11:42 AM, Markus Armbruster wrote: > Well, to suggest something, I'd first have to figure out WTF incremental block migration does. Your text helps me some, but not enough. What exactly is being migrated, and what exactly is

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Eric Blake writes: > On 05/16/2017 11:42 AM, Markus Armbruster wrote: > Well, to suggest something, I'd first have to figure out WTF incremental block migration does. Your text helps me some, but not enough. What exactly is being migrated, and what exactly is

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

On 05/16/2017 11:42 AM, Markus Armbruster wrote: >>> Well, to suggest something, I'd first have to figure out WTF incremental >>> block migration does. Your text helps me some, but not enough. What >>> exactly is being migrated, and what exactly is assumed to be shared >>> between source and

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Eric Blake writes: > On 05/16/2017 11:00 AM, Markus Armbruster wrote: > > # periodic mode. (Since 2.8) > # > +# @block-incremental: enable block incremental migration (Since 2.10) > +# What's "block incremental migration" and why should I

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

On 05/16/2017 11:00 AM, Markus Armbruster wrote: # periodic mode. (Since 2.8) # +# @block-incremental: enable block incremental migration (Since 2.10) +# >>> >>> What's "block incremental migration" and why should I care? >> >> This is good, I will try. >> >> "block

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Create one capability for block migration and one parameter for >>> incremental block migration. >>> >>> Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Markus Armbruster wrote: > Juan Quintela writes: > >> Create one capability for block migration and one parameter for >> incremental block migration. >> >> Signed-off-by: Juan Quintela >> >> /* The last error that occurred */

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

Juan Quintela writes: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela > --- > hmp.c | 13 +++ > include/migration/block.h | 2 + >

[Qemu-devel] [PATCH 2/5] migration: Create block capability

Create one capability for block migration and one parameter for incremental block migration. Signed-off-by: Juan Quintela --- hmp.c | 13 +++ include/migration/block.h | 2 + include/migration/migration.h | 7 migration/migration.c