Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

2016-02-04 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote: > > * Amit Shah (amit.s...@redhat.com) wrote: > > > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: > > > > Rename the 'file' member of MigrationState to 'to_dst_file'. > > > > > >

Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

2016-02-04 Thread Amit Shah
On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: > Rename the 'file' member of MigrationState to 'to_dst_file'. Why? (Use this space to explain why you're doing it, rather than repeating the first line of the commit. It helps when reviewing the git logs later.) Thanks,

Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

2016-02-04 Thread Hailiang Zhang
On 2016/2/4 19:10, Dr. David Alan Gilbert wrote: * Amit Shah (amit.s...@redhat.com) wrote: On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote: * Amit Shah (amit.s...@redhat.com) wrote: On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: Rename the 'file' member of MigrationState

Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

2016-02-04 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: > > Rename the 'file' member of MigrationState to 'to_dst_file'. > > Why? > > (Use this space to explain why you're doing it, rather than repeating > the first line of the commit. It helps when

Re: [Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

2016-02-04 Thread Amit Shah
On (Thu) 04 Feb 2016 [10:50:16], Dr. David Alan Gilbert wrote: > * Amit Shah (amit.s...@redhat.com) wrote: > > On (Fri) 15 Jan 2016 [11:37:42], zhanghailiang wrote: > > > Rename the 'file' member of MigrationState to 'to_dst_file'. > > > > Why? > > > > (Use this space to explain why you're doing

[Qemu-devel] [PATCH 2/6] migration: Rename the'file' member of MigrationState

2016-01-14 Thread zhanghailiang
Rename the 'file' member of MigrationState to 'to_dst_file'. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 2 +- migration/exec.c | 4 +-- migration/fd.c|