I've made this similar to snapshots, but now I think...
Why should we maintain dirty bitmap directory in ram? This only gives us
saving of one extra bdrv_read of header on loading bitmap, but is
doesn't matter in comparison with reading the whole bitmap to memory.
Also, the bitmap should not
On Fri, Aug 14, 2015 at 08:14:46PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 10.06.2015 17:30, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
+ret = bdrv_pread(bs-file, bm-l1_table_offset, l1_table,
+ bm-l1_size
On 13.06.2015 00:55, John Snow wrote:
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
On 26.08.2015 16:15, Vladimir Sementsov-Ogievskiy wrote:
On 13.06.2015 00:55, John Snow wrote:
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
On 10.06.2015 17:30, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
+ret = bdrv_pread(bs-file, bm-l1_table_offset, l1_table,
+ bm-l1_size * sizeof(uint64_t));
+if (ret 0) {
+goto fail;
+}
+
+
On Tue, Jun 23, 2015 at 01:57:55PM -0400, John Snow wrote:
On 06/15/2015 10:42 AM, Stefan Hajnoczi wrote:
On Fri, Jun 12, 2015 at 03:02:33PM -0400, John Snow wrote:
On 06/10/2015 10:30 AM, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy
On 06/15/2015 10:42 AM, Stefan Hajnoczi wrote:
On Fri, Jun 12, 2015 at 03:02:33PM -0400, John Snow wrote:
On 06/10/2015 10:30 AM, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy
wrote:
I noticed a corner case, it's probably not a problem in
On 12.06.2015 02:04, John Snow wrote:
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy
On Fri, Jun 12, 2015 at 03:02:33PM -0400, John Snow wrote:
On 06/10/2015 10:30 AM, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy
wrote:
I noticed a corner case, it's probably not a problem in practice:
Since the dirty bitmap is
On 06/15/2015 10:05 AM, Vladimir Sementsov-Ogievskiy wrote:
On 12.06.2015 02:04, John Snow wrote:
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
On 06/10/2015 10:30 AM, Stefan Hajnoczi wrote:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
I noticed a corner case, it's probably not a problem in practice:
Since the dirty bitmap is stored with the help of a BlockDriverState
(and its bs-file), it's
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Signed-off-by:
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Signed-off-by:
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
I noticed a corner case, it's probably not a problem in practice:
Since the dirty bitmap is stored with the help of a BlockDriverState
(and its bs-file), it's possible that writing the bitmap will cause
bits in the
On Mon, Jun 08, 2015 at 06:21:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
I haven't fully reviewed this patch yet but here are initial comments.
+int qcow2_read_dirty_bitmaps(BlockDriverState *bs)
+{
+BDRVQcowState *s = bs-opaque;
+QCowDirtyBitmapHeader h;
+QCowDirtyBitmap
From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Adds dirty-bitmaps feature to qcow2 format as specified in
docs/specs/qcow2.txt
Signed-off-by: Vladimir Sementsov-Ogievskiy vsement...@parallels.com
Signed-off-by: Vladimir Sementsov-Ogievskiy vsement...@virtuozzo.com
---
16 matches
Mail list logo
