Re: [Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific

2016-05-17 Thread Paolo Bonzini
On 17/05/2016 16:24, Max Filippov wrote: >> > Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions >> > of private methods, as well as all type definitions that require knowledge >> > of the layout to cpu.h. Conversely, move all definitions needed to >> > define a class to

Re: [Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific

2016-05-17 Thread Max Filippov
Hi Paolo, On Mon, May 16, 2016 at 05:35:52PM +0200, Paolo Bonzini wrote: > Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions > of private methods, as well as all type definitions that require knowledge > of the layout to cpu.h. Conversely, move all definitions needed to >

[Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific

2016-05-16 Thread Paolo Bonzini
Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. Conversely, move all definitions needed to define a class to cpu-qom.h. This helps making files independent of NEED_CPU_H if

[Qemu-devel] [PATCH 20/50] target-xtensa: make cpu-qom.h not target specific

2016-04-08 Thread Paolo Bonzini
Make XtensaCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. Conversely, move all definitions needed to define a class to cpu-qom.h. This helps making files independent of NEED_CPU_H if