Re: [Qemu-devel] [PATCH 24/31] vl: Clean up error reporting in vnc_init_func()

2018-10-11 Thread Markus Armbruster
Markus Armbruster writes: > Calling error_report() in a function that takes an Error ** argument > is suspicious. vnc_init_func() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean it up anyway. > > Cc: Gerd Hoffmann >

Re: [Qemu-devel] [PATCH 24/31] vl: Clean up error reporting in vnc_init_func()

2018-10-09 Thread Marc-André Lureau
Hi On Mon, Oct 8, 2018 at 9:38 PM Markus Armbruster wrote: > > Calling error_report() in a function that takes an Error ** argument > is suspicious. vnc_init_func() does that, and then fails without > setting an error. Its caller main(), via qemu_opts_foreach(), is fine > with it, but clean it

[Qemu-devel] [PATCH 24/31] vl: Clean up error reporting in vnc_init_func()

2018-10-08 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. vnc_init_func() does that, and then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway. Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster --- u