Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Paolo Bonzini
On 02/23/2012 11:19 AM, Federico Simoncelli wrote: >>> I'm worried that blkmirror does not satisfy _all_ mirroring >>> needs, for example you cannot use block_stream to copy from the >>> source to the destination, so perhaps in the future we want to >>> change it to something else. > > Are you tal

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Paolo Bonzini" > To: "Federico Simoncelli" > Cc: kw...@redhat.com, mtosa...@redhat.com, qemu-devel@nongnu.org > Sent: Thursday, February 23, 2012 10:48:59 AM > Subject: Re: [PATCH 3/3] Add nocreate option to snapshot_blkdev > > On 02/23/2012 10:39 AM, Federi

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Paolo Bonzini
On 02/23/2012 10:39 AM, Federico Simoncelli wrote: > I agree on the fact that using snapshot_blkdev is a misnomer but at > the same time I like very much how blkmirror is modular and it can > be used as a regular image filename. True, on the other hand if we add this we will have to keep it foreve

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-23 Thread Federico Simoncelli
- Original Message - > From: "Paolo Bonzini" > Cc: "Federico Simoncelli" , kw...@redhat.com, > mtosa...@redhat.com, qemu-devel@nongnu.org > Sent: Thursday, February 23, 2012 8:38:55 AM > Subject: Re: [PATCH 3/3] Add nocreate option to snapshot_blkdev > > On 02/23/2012 08:19 AM, Paolo Bon

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-22 Thread Paolo Bonzini
On 02/23/2012 08:19 AM, Paolo Bonzini wrote: >> > Signed-off-by: Federico Simoncelli > What is the usecase, and how can this be tested? Oops, you explained it in part 0. > Step 5 - Final Switch to Destination > > VM1 is now able to switch to the destination f

Re: [Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-22 Thread Paolo Bonzini
On 02/22/2012 06:13 PM, Federico Simoncelli wrote: > Signed-off-by: Federico Simoncelli What is the usecase, and how can this be tested? Paolo

[Qemu-devel] [PATCH 3/3] Add nocreate option to snapshot_blkdev

2012-02-22 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli --- blockdev.c | 14 -- hmp-commands.hx | 16 ++-- hmp.c|4 +++- qapi-schema.json |8 +++- qmp-commands.hx |2 +- 5 files changed, 29 insertions(+), 15 deletions(-) diff --git a/blockdev.c b/blockd