Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-04-03 Thread Andrey Shinkevich
On 29/03/2019 19:07, Alberto Garcia wrote: > On Fri 29 Mar 2019 02:29:14 PM CET, Andrey Shinkevich wrote: >> @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char >> *job_id, const char *device, >> job_flags |= JOB_MANUAL_DISMISS; >> } >> >> -

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-04-02 Thread Alberto Garcia
On Tue 02 Apr 2019 10:51:06 AM CEST, Andrey Shinkevich wrote: > @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char > *job_id, const char *device, >job_flags |= JOB_MANUAL_DISMISS; >} > > -stream_start(has_job_id ? job_id :

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-04-02 Thread Vladimir Sementsov-Ogievskiy
02.04.2019 11:51, Andrey Shinkevich wrote: > > > On 01/04/2019 18:44, Alberto Garcia wrote: >> On Fri 29 Mar 2019 05:15:43 PM CET, Vladimir Sementsov-Ogievskiy wrote: > @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char > *job_id, const char *device, >

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-04-02 Thread Andrey Shinkevich
On 01/04/2019 18:44, Alberto Garcia wrote: > On Fri 29 Mar 2019 05:15:43 PM CET, Vladimir Sementsov-Ogievskiy wrote: @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char *job_id, const char *device, job_flags |= JOB_MANUAL_DISMISS; }

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-04-01 Thread Alberto Garcia
On Fri 29 Mar 2019 05:15:43 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char >>> *job_id, const char *device, >>> job_flags |= JOB_MANUAL_DISMISS; >>> } >>> >>> -stream_start(has_job_id ? job_id : NULL,

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 19:07, Alberto Garcia wrote: > On Fri 29 Mar 2019 02:29:14 PM CET, Andrey Shinkevich wrote: >> @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char >> *job_id, const char *device, >> job_flags |= JOB_MANUAL_DISMISS; >> } >> >> -

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-03-29 Thread Andrey Shinkevich
On 29/03/2019 19:07, Alberto Garcia wrote: > On Fri 29 Mar 2019 02:29:14 PM CET, Andrey Shinkevich wrote: >> @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char >> *job_id, const char *device, >> job_flags |= JOB_MANUAL_DISMISS; >> } >> >> -

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-03-29 Thread Vladimir Sementsov-Ogievskiy
29.03.2019 16:29, Andrey Shinkevich wrote: > The bottom node is the intermediate block device that has the base as its > backing image. It is used instead of the base node while a block stream > job is running to avoid dependency on the base that may change due to the > parallel jobs. The change

Re: [Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-03-29 Thread Alberto Garcia
On Fri 29 Mar 2019 02:29:14 PM CET, Andrey Shinkevich wrote: > @@ -3237,7 +3238,14 @@ void qmp_block_stream(bool has_job_id, const char > *job_id, const char *device, > job_flags |= JOB_MANUAL_DISMISS; > } > > -stream_start(has_job_id ? job_id : NULL, bs, base_bs, base_name, >

[Qemu-devel] [PATCH 3/3] block/stream: introduce a bottom node

2019-03-29 Thread Andrey Shinkevich
The bottom node is the intermediate block device that has the base as its backing image. It is used instead of the base node while a block stream job is running to avoid dependency on the base that may change due to the parallel jobs. The change may take place due to a filter node as well that is