Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-12 Thread Peter Maydell
On 12 November 2018 at 17:38, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> That would require us to support backing it properly with a block >> device, like the pflash flash devices, I think. (This would >> be the long term way to be able to dump the

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 9 November 2018 at 17:19, Corey Minyard wrote: > > On 11/9/18 9:02 AM, Peter Maydell wrote: > >> The data provided by the caller is only the initialization > >> data. So I think the device should create its own memory > >> to copy that init

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-12 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 8 November 2018 at 17:58, Corey Minyard wrote: > > On 11/8/18 8:08 AM, Peter Maydell wrote: > >> This doesn't do anything for migration of the actual data contents. > >> The current users of this device (hw/arm/aspeed.c and the > >>

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 17:19, Corey Minyard wrote: > On 11/9/18 9:02 AM, Peter Maydell wrote: >> The data provided by the caller is only the initialization >> data. So I think the device should create its own memory >> to copy that init data into, and migrate that ram, not >> wherever the

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-09 Thread Corey Minyard
On 11/9/18 9:02 AM, Peter Maydell wrote: On 9 November 2018 at 14:56, Corey Minyard wrote: On 11/8/18 12:03 PM, Peter Maydell wrote: On 8 November 2018 at 17:58, Corey Minyard wrote: On 11/8/18 8:08 AM, Peter Maydell wrote: This doesn't do anything for migration of the actual data

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-09 Thread Peter Maydell
On 9 November 2018 at 14:56, Corey Minyard wrote: > On 11/8/18 12:03 PM, Peter Maydell wrote: >> >> On 8 November 2018 at 17:58, Corey Minyard wrote: >>> >>> On 11/8/18 8:08 AM, Peter Maydell wrote: This doesn't do anything for migration of the actual data contents. The current

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-09 Thread Corey Minyard
On 11/8/18 12:03 PM, Peter Maydell wrote: On 8 November 2018 at 17:58, Corey Minyard wrote: On 11/8/18 8:08 AM, Peter Maydell wrote: This doesn't do anything for migration of the actual data contents. The current users of this device (hw/arm/aspeed.c and the smbus_eeprom_init() function)

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-08 Thread Peter Maydell
On 8 November 2018 at 17:58, Corey Minyard wrote: > On 11/8/18 8:08 AM, Peter Maydell wrote: >> This doesn't do anything for migration of the actual data contents. >> The current users of this device (hw/arm/aspeed.c and the >> smbus_eeprom_init() function) doesn't do anything >> to migrate the

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-08 Thread Corey Minyard
On 11/8/18 8:08 AM, Peter Maydell wrote: On 7 November 2018 at 15:54, wrote: From: Corey Minyard This was if the eeprom is accessed during a state transfer, the transfer will be reliable. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-08 Thread Peter Maydell
On 7 November 2018 at 15:54, wrote: > From: Corey Minyard > > This was if the eeprom is accessed during a state transfer, the > transfer will be reliable. > > Signed-off-by: Corey Minyard > Cc: Paolo Bonzini > Cc: Michael S. Tsirkin > Cc: Dr. David Alan Gilbert > --- >

[Qemu-devel] [PATCH 3/3] i2c: Add vmstate handling to the smbus eeprom

2018-11-07 Thread minyard
From: Corey Minyard This was if the eeprom is accessed during a state transfer, the transfer will be reliable. Signed-off-by: Corey Minyard Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Dr. David Alan Gilbert --- hw/i2c/smbus_eeprom.c | 16 +++- 1 file changed, 15 insertions(+),