Re: [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-15 Thread Ashijeet Acharya
On Thu, Dec 15, 2016 at 11:21 PM, John Snow wrote: > > > On 12/15/2016 12:11 PM, Dr. David Alan Gilbert wrote: >> if (virtio_gpu_virgl_enabled(g->conf)) { >> +error_setg(>migration_blocker, "virgl is not yet migratable"); >> +ret =

Re: [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-15 Thread John Snow
On 12/15/2016 12:11 PM, Dr. David Alan Gilbert wrote: > if (virtio_gpu_virgl_enabled(g->conf)) { > +error_setg(>migration_blocker, "virgl is not yet migratable"); > +ret = migrate_add_blocker(g->migration_blocker, errp); > +if (ret) { > +if (ret > 0) { >

Re: [Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-15 Thread Dr. David Alan Gilbert
* Ashijeet Acharya (ashijeetacha...@gmail.com) wrote: > If a migration is already in progress and somebody attempts > to add a migration blocker, this should rightly fail. > > Also, it should fail if the '--only-migratable' option was specified > and the device in use should not be able to

[Qemu-devel] [PATCH 3/3] migration: disallow migrate_add_blocker during migration

2016-12-14 Thread Ashijeet Acharya
If a migration is already in progress and somebody attempts to add a migration blocker, this should rightly fail. Also, it should fail if the '--only-migratable' option was specified and the device in use should not be able to perform the action which results in an unmigratable VM. Add an errp