subject:"\[Qemu\-devel\] \[PATCH 3\/3\] savevm\: avoid leaking popen\(3\) file pointer"

Re: [Qemu-devel] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

2013-05-30 Thread Eric Blake

On 05/30/2013 08:14 AM, Stefan Hajnoczi wrote: I'm not sure why we check the mode only after invoking popen(3) but we need to close the file pointer. Spotted by Coverity. Cc: Juan Quintela quint...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

2013-05-30 Thread Stefan Hajnoczi

I'm not sure why we check the mode only after invoking popen(3) but we need to close the file pointer. Spotted by Coverity. Cc: Juan Quintela quint...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- savevm.c | 1 + 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 3/3] savevm: avoid leaking popen(3) file pointer

2013-05-30 Thread Stefan Hajnoczi

On Thu, May 30, 2013 at 4:25 PM, Eric Blake ebl...@redhat.com wrote: On 05/30/2013 08:14 AM, Stefan Hajnoczi wrote: I'm not sure why we check the mode only after invoking popen(3) but we need to close the file pointer. Spotted by Coverity. Cc: Juan Quintela quint...@redhat.com Cc: