Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-08 Thread Paul Brook
+static void i8042_isa_mouse_fake_event(void *opaque, int n, int level) { ISADevice *dev = opaque; KBDState *s = (DO_UPCAST(ISAKBDState, dev, dev)-kbd); -ps2_mouse_fake_event(s-mouse); +if (level) { +ps2_mouse_fake_event(s-mouse); +} } ... @@ -99,7

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-07 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc.c |7 +++ hw/pc.h |1 - hw/pckbd.c |7 +-- hw/vmmouse.c | 11 +++ 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/pc.c

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-07 Thread Paolo Bonzini
On 02/07/2012 01:39 PM, Juan Quintela wrote: vmmouse = isa_try_create(isa_bus, vmmouse); +qdev_init_nofail(vmmouse-qdev); +qdev_connect_gpio_out(DEVICE(vmmouse), 0, + qdev_get_gpio_in(DEVICE(i8042), 0)); Are you sue that vmmouse is

[Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc.c |7 +++ hw/pc.h |1 - hw/pckbd.c |7 +-- hw/vmmouse.c | 11 +++ 4 files changed, 11 insertions(+), 15 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 7f3aa65..76787c7 100644 --- a/hw/pc.c +++

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-04 Thread Gerhard Wiesinger
Hello Paolo, What will be fixed/enhanced by this patch? Scenario? Can you also add a more detailed commit message. Thnx. Ciao, Gerhard -- http://www.wiesinger.com/ On Sat, 4 Feb 2012, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/pc.c |7 +++

Re: [Qemu-devel] [PATCH 3/3] vmmouse: replace PROP_PTR property with gpio pin to i8042

2012-02-04 Thread Paolo Bonzini
On 02/04/2012 02:03 PM, Gerhard Wiesinger wrote: Hello Paolo, What will be fixed/enhanced by this patch? Scenario? Nothing, it's just a cleanup. It's a step towards removing PROP_PTR. Paolo