Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-12 Thread Orit Wasserman
On 09/11/2013 02:27 PM, Paolo Bonzini wrote: > Il 11/09/2013 13:06, Juan Quintela ha scritto: And I think that the right solution is make qemu_get_rate_limit() to return -1 in case of error (or the error, I don't care). >>> >>> You might do both things, it would avoid the useless g_usleep

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-12 Thread Lei Li
On 09/11/2013 07:27 PM, Paolo Bonzini wrote: Il 11/09/2013 13:06, Juan Quintela ha scritto: And I think that the right solution is make qemu_get_rate_limit() to return -1 in case of error (or the error, I don't care). You might do both things, it would avoid the useless g_usleep you pointed out

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 13:06, Juan Quintela ha scritto: >>> And I think that the right solution is make qemu_get_rate_limit() to >>> return -1 in case of error (or the error, I don't care). >> >> You might do both things, it would avoid the useless g_usleep you >> pointed out below. But Lei's patch is good

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Juan Quintela
Paolo Bonzini wrote: > Il 11/09/2013 11:17, Juan Quintela ha scritto: >> Lei Li wrote: >>> qemu_file_rate_limit() never return negative value since the refactor >>> by Commit 1964a39, this patch gets rid of the negative check for it, >>> adjust bytes_transferred and return value correspondingly i

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Paolo Bonzini
Il 11/09/2013 11:17, Juan Quintela ha scritto: > Lei Li wrote: >> qemu_file_rate_limit() never return negative value since the refactor >> by Commit 1964a39, this patch gets rid of the negative check for it, >> adjust bytes_transferred and return value correspondingly in >> ram_save_iterate(). >>

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-11 Thread Juan Quintela
Lei Li wrote: > qemu_file_rate_limit() never return negative value since the refactor > by Commit 1964a39, this patch gets rid of the negative check for it, > adjust bytes_transferred and return value correspondingly in > ram_save_iterate(). > > Signed-off-by: Lei Li > Signed-off-by: Paolo Bonzi

[Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-04 Thread Lei Li
qemu_file_rate_limit() never return negative value since the refactor by Commit 1964a39, this patch gets rid of the negative check for it, adjust bytes_transferred and return value correspondingly in ram_save_iterate(). Signed-off-by: Lei Li Signed-off-by: Paolo Bonzini --- Change since v1: