Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-29 Thread Tan, Jianfeng
On 11/29/2017 5:11 PM, Paolo Bonzini wrote: On 29/11/2017 05:10, Michael S. Tsirkin wrote: " Interrupt mode for vhost-user is still not supported in current implementation. But we are evaluating the necessity now. That's more or less a spec violation. Guest must get interrupts if it does not

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-29 Thread Paolo Bonzini
On 29/11/2017 05:10, Michael S. Tsirkin wrote: >> " Interrupt mode for vhost-user is still not supported in current >> implementation. But we are evaluating the necessity now. > > That's more or less a spec violation. Guest must get interrupts > if it does not disable them. And it must notify hos

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Michael S. Tsirkin
On Wed, Nov 29, 2017 at 02:33:59AM +, Gonglei (Arei) wrote: > > > -Original Message- > > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > Sent: Tuesday, November 28, 2017 7:20 PM > > To: Gonglei (Arei); qemu-devel@nongnu.org > > Cc: m...@redhat.com; Huangweidong (C); stefa...@redha

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 7:20 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng; xin.z...@intel.

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Michael S. Tsirkin
On Tue, Nov 28, 2017 at 11:45:31AM +0100, Paolo Bonzini wrote: > On 28/11/2017 11:43, Gonglei (Arei) wrote: > >> As far as I understand, VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is called as > >> a result of sending a message on the control virtqueue. > > > > VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is a mes

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 12:06, Gonglei (Arei) wrote: >>> You mean we can share control virtqueue to DPDK as well? Like data queues? >> I don't know :) but why not? >> > Current there are two main reasons for this design: > > 1) we should use another cpu to polling the control virtqueue, which is > expensiv

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 6:46 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng; xin.z...@intel.

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 11:43, Gonglei (Arei) wrote: >> As far as I understand, VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is called as >> a result of sending a message on the control virtqueue. > > VIRTIO_CRYPTO_CIPHER_CREATE_SESSION is a message type of control queue, > Means creating a session for next crypto re

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, November 28, 2017 6:02 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); stefa...@redhat.com; Zhoujian > (jay); pa...@linux.vnet.ibm.com; longpeng; xin.z...@intel.

Re: [Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Paolo Bonzini
On 28/11/2017 10:03, Gonglei wrote: > Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION > and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side > support crypto operation in cryptodev host-user backend. > > Signed-off-by: Gonglei > Signed-off-by: Longpeng(Mike) > Si

[Qemu-devel] [PATCH 3/4] cryptodev-vhost-user: add crypto session handler

2017-11-28 Thread Gonglei
Introduce two vhost-user meassges: VHOST_USER_CREATE_CRYPTO_SESSION and VHOST_USER_CLOSE_CRYPTO_SESSION. At this point, the QEMU side support crypto operation in cryptodev host-user backend. Signed-off-by: Gonglei Signed-off-by: Longpeng(Mike) Signed-off-by: Zhoujian --- backends/cryptodev-vho