Re: [Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save logic

2013-10-15 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: This makes the code more readable, making each condition that makes a field be skipped much more visible, and reduces one level of indentation in the code. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- savevm.c | 156

Re: [Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save logic

2013-10-15 Thread Paolo Bonzini
Il 14/10/2013 18:45, Eduardo Habkost ha scritto: +if (field-field_exists !field-field_exists(opaque, version_id)) { +continue; +} +if (field-version_id version_id) { +continue; +} What Markus observed... I think the change is fine

Re: [Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save logic

2013-10-15 Thread Eduardo Habkost
On Tue, Oct 15, 2013 at 10:01:12AM +0200, Markus Armbruster wrote: Eduardo Habkost ehabk...@redhat.com writes: This makes the code more readable, making each condition that makes a field be skipped much more visible, and reduces one level of indentation in the code. Signed-off-by:

[Qemu-devel] [PATCH 3/5] vmstate: Simplify field-skipping load/save logic

2013-10-14 Thread Eduardo Habkost
This makes the code more readable, making each condition that makes a field be skipped much more visible, and reduces one level of indentation in the code. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- savevm.c | 156 --- 1