Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-23 Thread Stefan Hajnoczi
On Sun, Aug 21, 2016 at 02:15:31PM +0200, Lluís Vilanova wrote: > > Can this approach be made thread-safe? > > > If not then it would be good to consider the problem right away and > > switch to something that is thread-safe, even if it depends on the > > target architecture. > > Kind of. The

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-21 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Aug 05, 2016 at 06:59:39PM +0200, Lluís Vilanova wrote: >> +static void init_channel(const char *base, const char *suffix, size_t size, >> + char ** path, int *fd, uint64_t **addr) >> +{ >> +*path = g_malloc(strlen(base) +

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 05, 2016 at 06:59:39PM +0200, Lluís Vilanova wrote: > +static void init_channel(const char *base, const char *suffix, size_t size, > + char ** path, int *fd, uint64_t **addr) > +{ > +*path = g_malloc(strlen(base) + strlen(suffix) + 1); > +sprintf(*path,

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-08 Thread Lluís Vilanova
Eric Blake writes: > On 08/05/2016 10:59 AM, Lluís Vilanova wrote: >> QEMU detects when the guest uses 'mmap' on hypertrace's control channel >> file, and then uses 'mprotect' to detect accesses to it, which are used >> to trigger traceing event "guest_hypertrace". > s/traceing/tracing/ > I'll

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-05 Thread Eric Blake
On 08/05/2016 10:59 AM, Lluís Vilanova wrote: > QEMU detects when the guest uses 'mmap' on hypertrace's control channel > file, and then uses 'mprotect' to detect accesses to it, which are used > to trigger traceing event "guest_hypertrace". s/traceing/tracing/ I'll probably leave the technical

[Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-05 Thread Lluís Vilanova
QEMU detects when the guest uses 'mmap' on hypertrace's control channel file, and then uses 'mprotect' to detect accesses to it, which are used to trigger traceing event "guest_hypertrace". Signed-off-by: Lluís Vilanova --- Makefile.objs|4 + bsd-user/main.c