Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 23 March 2015 at 12:56, John Snow js...@redhat.com wrote: My pattern was cyclical every 256 bytes, so it missed a fairly obvious failure case. Add some rand() pepper into the test pattern, and for large patterns that exceed 256 sectors, start writing an ID per-sector so that we never

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 05:55 PM, Ed Maste wrote: On 31 March 2015 at 17:44, John Snow js...@redhat.com wrote: My apologies; Not at all, thanks for your help! Head into your build directory and try this: make tests/ahci-test export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 export

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 16:58, John Snow js...@redhat.com wrote: which test case does it fail under? io_rw_simple is shared by a number of different tests. I'm not sure off hand how to run an individual test to confirm, but the testrun output up to the failure is: LINK tests/spapr-phb-test

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:44, John Snow js...@redhat.com wrote: My apologies; Not at all, thanks for your help! Head into your build directory and try this: make tests/ahci-test export QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 export QTEST_QEMU_IMG=./qemu-img ./tests/ahci-test This

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 05:29 PM, Ed Maste wrote: On 31 March 2015 at 16:58, John Snow js...@redhat.com wrote: which test case does it fail under? io_rw_simple is shared by a number of different tests. I'm not sure off hand how to run an individual test to confirm, but the testrun output up to the

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 04:55 PM, Ed Maste wrote: On 23 March 2015 at 12:56, John Snow js...@redhat.com wrote: My pattern was cyclical every 256 bytes, so it missed a fairly obvious failure case. Add some rand() pepper into the test pattern, and for large patterns that exceed 256 sectors, start writing

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread Ed Maste
On 31 March 2015 at 17:55, Ed Maste ema...@freebsd.org wrote: feynman% ./tests/ahci-test /i386/ahci/sanity: OK /i386/ahci/pci_spec: OK /i386/ahci/pci_enable: OK /i386/ahci/hba_spec: OK /i386/ahci/hba_enable: OK /i386/ahci/identify: OK /i386/ahci/io/pio/lba28/simple: **

Re: [Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-31 Thread John Snow
On 03/31/2015 08:29 PM, Ed Maste wrote: On 31 March 2015 at 17:55, Ed Maste ema...@freebsd.org wrote: feynman% ./tests/ahci-test /i386/ahci/sanity: OK /i386/ahci/pci_spec: OK /i386/ahci/pci_enable: OK /i386/ahci/hba_spec: OK /i386/ahci/hba_enable: OK /i386/ahci/identify: OK

[Qemu-devel] [PATCH 4/4] ahci-test: improve rw buffer patterns

2015-03-23 Thread John Snow
My pattern was cyclical every 256 bytes, so it missed a fairly obvious failure case. Add some rand() pepper into the test pattern, and for large patterns that exceed 256 sectors, start writing an ID per-sector so that we never generate identical sector patterns. Signed-off-by: John Snow