Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c

2016-03-19 Thread Paolo Bonzini
On 16/03/2016 10:24, xiaoqiang zhao wrote: > s->voice_out = AUD_open_out(&s->card, s->voice_out, > "mm_ac97.out", s, ac97_out_cb, &as); > AUD_open_out should not be done before realize. Paolo

Re: [Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c

2016-03-18 Thread xiaoqiang zhao
在 2016年03月17日 00:30, Paolo Bonzini 写道: On 16/03/2016 10:24, xiaoqiang zhao wrote: s->voice_out = AUD_open_out(&s->card, s->voice_out, "mm_ac97.out", s, ac97_out_cb, &as); AUD_open_out should not be done before realize. Paolo I wil move it to DeviceClasss::realize in

[Qemu-devel] [PATCH 4/4] hw/audio: QOM'ify milkymist-ac97.c

2016-03-16 Thread xiaoqiang zhao
Drop the old SysBus init function and use instance_init Signed-off-by: xiaoqiang zhao --- hw/audio/milkymist-ac97.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/audio/milkymist-ac97.c b/hw/audio/milkymist-ac97.c index 6a3b536..ac78e00 100644 --- a/hw/audio