[Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- drivers/net/virtio_net.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com I don't mind, but driver should

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Zhi Yong Wu
On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs currently used by the driver instead of a magic value.

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 06:07:45PM +0800, Zhi Yong Wu wrote: On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com It is more appropriate to use # of queue pairs

Re: [Qemu-devel] [PATCH 4/4] net, virtio_net: replace the magic value

2013-11-18 Thread Zhi Yong Wu
On Mon, Nov 18, 2013 at 6:15 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 06:07:45PM +0800, Zhi Yong Wu wrote: On Mon, Nov 18, 2013 at 5:50 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Nov 18, 2013 at 04:46:20PM +0800, Zhi Yong Wu wrote: From: Zhi Yong Wu