On 02/21/13 12:02, David Woodhouse wrote:
> On Thu, 2013-02-21 at 09:17 +, David Woodhouse wrote:
>> Thanks. I suppose I'd better test that I haven't broken suspend/resume
>> first. I don't care about OS/2 or VDISK, but it's vaguely possible that
>> suspend/resume might be another "reset" user
On Thu, 2013-02-21 at 09:17 +, David Woodhouse wrote:
> Thanks. I suppose I'd better test that I haven't broken suspend/resume
> first. I don't care about OS/2 or VDISK, but it's vaguely possible that
> suspend/resume might be another "reset" user which actually *would* be
> offended if the PAM
On Thu, 2013-02-21 at 08:46 +0100, Paolo Bonzini wrote:
> You may go ahead and send a pull request (note that we do send the other
> patches together with a pull request, just the cover letter has [PULL
> 0/4] and the "git request-pull" output).
Thanks. I suppose I'd better test that I haven't bro
Il 21/02/2013 00:34, David Woodhouse ha scritto:
> On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote:
>>
>>
>> Reviewed-by: Andreas Färber
>>
>> A minor suggestion since you seem to be preparing a v2 would be to do
>> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime
>> soon
Am 21.02.2013 00:34, schrieb David Woodhouse:
> On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote:
>>
>>
>> Reviewed-by: Andreas Färber
>>
>> A minor suggestion since you seem to be preparing a v2 would be to do
>> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime
>> soon, t
On Thu, 2013-02-21 at 00:31 +0100, Andreas Färber wrote:
>
>
> Reviewed-by: Andreas Färber
>
> A minor suggestion since you seem to be preparing a v2 would be to do
> I440FX_PCI_DEVICE(ds), but I don't see dev becoming unused anytime
> soon, therefore moot.
Well it's only used because you told
Am 20.02.2013 22:46, schrieb David Woodhouse:
> From: David Woodhouse
>
> This implements reset functionality for the i440FX, resetting all the
> PAM registers to their power-on defaults of no RAM access and thus
> forwarding all access to the 0xc-0xf range to PCI address space
> (i.e. to
On 02/21/13 00:25, Laszlo Ersek wrote:
> On 02/20/13 22:46, David Woodhouse wrote:
>
>> +static void i440fx_reset(DeviceState *ds)
>> +{
>> +PCIDevice *dev = PCI_DEVICE(ds);
>> +PCII440FXState *d = I440FX_PCI_DEVICE(dev);
>> +uint8_t *pci_conf = dev->config;
>> +
>> +pci_conf[0x59]
On 02/20/13 22:46, David Woodhouse wrote:
> +static void i440fx_reset(DeviceState *ds)
> +{
> +PCIDevice *dev = PCI_DEVICE(ds);
> +PCII440FXState *d = I440FX_PCI_DEVICE(dev);
> +uint8_t *pci_conf = dev->config;
> +
> +pci_conf[0x59] = 0x00; /* Reset PAM setup */
> +pci_conf[0x5
From: David Woodhouse
This implements reset functionality for the i440FX, resetting all the
PAM registers to their power-on defaults of no RAM access and thus
forwarding all access to the 0xc-0xf range to PCI address space
(i.e. to the actual ROM) instead of RAM.
Fixing this is sufficien
10 matches
Mail list logo
