On 01/24/11 18:47, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
qemu_toupper() - whats the problem?
If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
will not match any input.
Right, so one has to be careful when adding new suffix constants.
Jes Sorensen jes.soren...@redhat.com writes:
On 01/24/11 18:47, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
qemu_toupper() - whats the problem?
If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
will not match any input.
Right, so one has to be
On 01/25/11 11:17, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
On 01/24/11 18:47, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
qemu_toupper() - whats the problem?
If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
will
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
index 369a016..8d562b2 100644
--- a/cutils.c
+++ b/cutils.c
@@ -324,26 +324,26 @@
On 01/24/11 17:08, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
index 369a016..8d562b2 100644
--- a/cutils.c
Jes Sorensen jes.soren...@redhat.com writes:
On 01/24/11 17:08, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5
On 01/24/11 17:39, Markus Armbruster wrote:
+case STRTOSZ_DEFSUFFIX_TB:
mul = 1ULL 40;
break;
default:
Phony abstraction. And it leaks: code here assumes the
STRTOSZ_DEFSUFFIX_T* are all upper case.
qemu_toupper() - whats the problem?
If a
Jes Sorensen jes.soren...@redhat.com writes:
On 01/24/11 17:39, Markus Armbruster wrote:
+case STRTOSZ_DEFSUFFIX_TB:
mul = 1ULL 40;
break;
default:
Phony abstraction. And it leaks: code here assumes the
STRTOSZ_DEFSUFFIX_T* are all upper case.