Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-08-13 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 10 August 2012 17:04, Anthony Liguori aligu...@us.ibm.com wrote: This lets us provide a default implementation of a symbol which targets can override. Signed-off-by: Anthony Liguori aligu...@us.ibm.com I'm sure you'll be thrilled to hear

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-08-12 Thread Peter Maydell
On 10 August 2012 17:04, Anthony Liguori aligu...@us.ibm.com wrote: This lets us provide a default implementation of a symbol which targets can override. Signed-off-by: Anthony Liguori aligu...@us.ibm.com I'm sure you'll be thrilled to hear that this doesn't seem to break MacOS builds :-) --

[Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-08-10 Thread Anthony Liguori
This lets us provide a default implementation of a symbol which targets can override. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- compiler.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/compiler.h b/compiler.h index 736e770..f76921e 100644 --- a/compiler.h

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-28 Thread Markus Armbruster
Anthony Liguori aligu...@us.ibm.com writes: Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori aligu...@us.ibm.com wrote: If someone comes along and actively maintains support for another compiler, we can revisit. But otherwise, there's no practical

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-28 Thread Peter Maydell
On 27 July 2012 16:31, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: My approach to this is to avoid non-standard things http://en.wikipedia.org/wiki/C99#Implementations So unless you plan on compiling QEMU with xlc, pgi, or icc, I don't think

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-28 Thread Blue Swirl
On Fri, Jul 27, 2012 at 10:40 PM, Anthony Liguori aligu...@us.ibm.com wrote: Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori aligu...@us.ibm.com wrote: If someone comes along and actively maintains support for another compiler, we can revisit. But

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-28 Thread Blue Swirl
On Sat, Jul 28, 2012 at 6:25 AM, Markus Armbruster arm...@redhat.com wrote: Anthony Liguori aligu...@us.ibm.com writes: Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori aligu...@us.ibm.com wrote: If someone comes along and actively maintains support

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-28 Thread Blue Swirl
On Sat, Jul 28, 2012 at 6:50 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 27 July 2012 16:31, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: My approach to this is to avoid non-standard things http://en.wikipedia.org/wiki/C99#Implementations

[Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
This lets us provide a default implementation of a symbol which targets can override. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- compiler.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/compiler.h b/compiler.h index 736e770..f76921e 100644 --- a/compiler.h

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Peter Maydell
On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: --- a/compiler.h +++ b/compiler.h @@ -45,6 +45,7 @@ # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) # endif +#define GCC_WEAK

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: --- a/compiler.h +++ b/compiler.h @@ -45,6 +45,7 @@ # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) # define GCC_FMT_ATTR(n, m)

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Peter Maydell
On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual says Weak symbols are supported for ELF targets, and also for a.out targets when using the GNU assembler and linker. Have you tested this on Windows and MacOSX ?

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual says Weak symbols are supported for ELF targets, and also for a.out targets when using the GNU assembler and linker.

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 14:37, Anthony Liguori aligu...@us.ibm.com wrote: --- a/compiler.h +++ b/compiler.h @@ -45,6 +45,7 @@ # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) # define GCC_FMT_ATTR(n, m)

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Blue Swirl
On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual says Weak symbols are supported for ELF

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: The GCC manual

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Blue Swirl
On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori aligu...@us.ibm.com wrote: Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 3:31 PM, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 27 July 2012 15:27, Anthony Liguori

Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols

2012-07-27 Thread Anthony Liguori
Blue Swirl blauwir...@gmail.com writes: On Fri, Jul 27, 2012 at 8:51 PM, Anthony Liguori aligu...@us.ibm.com wrote: If someone comes along and actively maintains support for another compiler, we can revisit. But otherwise, there's no practical reason to avoid extensions. Because it's more