Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

Markus Armbruster writes: > Marc-André Lureau writes: > >> Hi >> >> On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: >>> The existing users pass a func that saves dev, and free the saved dev >>> later. Works as long as

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

Hi On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: > The existing users pass a func that saves dev, and free the saved dev > later. Works as long as we call func() at most once. If multiple > devices match, all but the last one are leaked. Can this happen? It is

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

Marc-André Lureau writes: > Hi > > On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: >> The existing users pass a func that saves dev, and free the saved dev >> later. Works as long as we call func() at most once. If multiple >> devices

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > qpci_device_find() returns allocated data, don't leak it. > > Signed-off-by: Marc-André Lureau > --- > tests/libqos/pci.c | 2 ++ > 1 file changed, 2 insertions(+) > >

[Qemu-devel] [PATCH 4/8] libqos: remove some leaks

From: Marc-André Lureau qpci_device_find() returns allocated data, don't leak it. Signed-off-by: Marc-André Lureau --- tests/libqos/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c