Re: [Qemu-devel] [PATCH 4/8] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread Mark Cave-Ayland
On 18/09/17 21:36, David Gibson wrote: > On Sun, Sep 17, 2017 at 06:15:44PM +0100, Mark Cave-Ayland wrote: >> Signed-off-by: Mark Cave-Ayland > > Nice, but there are some details I'm not sure about. > >> --- >> hw/ide/macio.c | 154 >> +---

Re: [Qemu-devel] [PATCH 4/8] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread David Gibson
On Sun, Sep 17, 2017 at 06:15:44PM +0100, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Nice, but there are some details I'm not sure about. > --- > hw/ide/macio.c | 154 > +--- > 1 file changed, 56 insertions(+), 98 deletions(-)

[Qemu-devel] [PATCH 4/8] macio: convert pmac_ide_ops from old_mmio

2017-09-17 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 154 +--- 1 file changed, 56 insertions(+), 98 deletions(-) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index db5db39..428fbfc 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -255,131 +