Re: [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-05-19 Thread Cornelia Huck
On Thu, 19 May 2016 12:32:05 +0200 Paolo Bonzini wrote: > On 19/05/2016 12:17, Cornelia Huck wrote: > > On Mon, 16 May 2016 17:36:13 +0200 > > Paolo Bonzini wrote: > > > > Maybe mention which stuff was moved why ;) > > Right: > > > Move

Re: [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-05-19 Thread Paolo Bonzini
On 19/05/2016 12:17, Cornelia Huck wrote: > On Mon, 16 May 2016 17:36:13 +0200 > Paolo Bonzini wrote: > > Maybe mention which stuff was moved why ;) Right: Move cpu_inject_* to the only C file where they are used. Move ioinst.h declarations that need S390CPU to

Re: [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-05-19 Thread Cornelia Huck
On Mon, 16 May 2016 17:36:13 +0200 Paolo Bonzini wrote: Maybe mention which stuff was moved why ;) > Signed-off-by: Paolo Bonzini > --- > hw/s390x/css.c | 4 +- > hw/s390x/s390-skeys.c | 1 + >

[Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-05-16 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/s390x/css.c | 4 +- hw/s390x/s390-skeys.c | 1 + hw/s390x/s390-virtio-ccw.c | 4 +- hw/s390x/virtio-ccw.c | 5 +- hw/s390x/virtio-ccw.h

Re: [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-05-09 Thread Paolo Bonzini
On 11/04/2016 10:24, Cornelia Huck wrote: >> > +void cpu_inject_ext(S390CPU *cpu, uint32_t code, uint32_t param, >> > +uint64_t param64) > ...but this one can be both floating and per-vcpu. Need to adust the > comment above? > I've moved the comment to just above

Re: [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-04-11 Thread Cornelia Huck
On Fri, 8 Apr 2016 22:29:01 +0200 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/s390x/css.c | 4 +- > hw/s390x/s390-skeys.c | 1 + > hw/s390x/s390-virtio-ccw.c |

[Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h

2016-04-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/s390x/css.c | 4 +- hw/s390x/s390-skeys.c | 1 + hw/s390x/s390-virtio-ccw.c | 4 +- hw/s390x/virtio-ccw.c | 5 +- hw/s390x/virtio-ccw.h