Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-29 Thread Christoph Hellwig
On Fri, Jul 29, 2011 at 10:56:07AM +0200, Markus Armbruster wrote: > > Hmm. We already do proper read-modify-write cycles for actual data > > transfers, so killing the buffer inside SD sounds like the better > > idea. qemu_blockalign really should be used only for block-layer internal > > allocat

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-29 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: >> Device models should be able to use it without an unclean include of >> block_int.h. > > Hmm. We already do proper read-modify-write cycles for actual data > transfers, so killing the buffer inside

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-26 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: >> Device models should be able to use it without an unclean include of >> block_int.h. > > Hmm. We already do proper read-modify-write cycles for actual data > transfers, so killing the buffer inside

Re: [Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-26 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:24:23PM +0200, Markus Armbruster wrote: > Device models should be able to use it without an unclean include of > block_int.h. Hmm. We already do proper read-modify-write cycles for actual data transfers, so killing the buffer inside SD sounds like the better idea. qemu

[Qemu-devel] [PATCH 49/55] block: Declare qemu_blockalign() in block.h, not block_int.h

2011-07-20 Thread Markus Armbruster
Device models should be able to use it without an unclean include of block_int.h. Signed-off-by: Markus Armbruster --- block.h |2 ++ block_int.h |2 -- hw/sd.c |1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/block.h b/block.h index b6eaaba..8f52abb 10064