Re: [Qemu-devel] [PATCH 5/5] include/block/block_int: Document protocol related functions

2018-03-12 Thread Fabiano Rosas
On 2018-03-12 10:50, Max Reitz wrote: > A driver doesn't need to be a protocol driver for this, and technically > a protocol driver doesn't need to set this. Maybe we should rename it > to "filename_prefix"...? Yes, something that is closer to the filename string and farther from the notion of

Re: [Qemu-devel] [PATCH 5/5] include/block/block_int: Document protocol related functions

2018-03-12 Thread Max Reitz
On 2018-03-09 19:22, Fabiano Rosas wrote: > Clarify that for protocols the brdv_file_open function is used instead > of bdrv_open and that protocol_name is expected to be set. > > Signed-off-by: Fabiano Rosas > --- > include/block/block_int.h | 6 ++ > 1 file

[Qemu-devel] [PATCH 5/5] include/block/block_int: Document protocol related functions

2018-03-09 Thread Fabiano Rosas
Clarify that for protocols the brdv_file_open function is used instead of bdrv_open and that protocol_name is expected to be set. Signed-off-by: Fabiano Rosas --- include/block/block_int.h | 6 ++ 1 file changed, 6 insertions(+) diff --git