Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-06 Thread Paolo Bonzini
On 07/06/2011 08:20 AM, Hannes Reinecke wrote: We cannot map control structures from guest memory and treating them as valid request state later on. Yes, I've been working on that one already. What I'll be doing is to read in the sge count during 'map_sgl' and store this value internally (in -

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Hannes Reinecke
On 07/05/2011 05:21 PM, Stefan Hajnoczi wrote: On Tue, Jul 5, 2011 at 12:03 PM, Hannes Reinecke wrote: +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd) +{ +uint16_t flags = le16_to_cpu(cmd->frame->header.flags); +int i, is_write = (flags& MFI_FRAME_DIR_WRITE) ? 1 : 0; + +f

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:03 PM, Hannes Reinecke wrote: > +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd) > +{ > +    uint16_t flags = le16_to_cpu(cmd->frame->header.flags); > +    int i, is_write = (flags & MFI_FRAME_DIR_WRITE) ? 1 : 0; > + > +    for (i = 0; i < cmd->frame->header.sge_

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 03:59 PM, Paolo Bonzini wrote: On 07/05/2011 03:38 PM, Alexander Graf wrote: +if (is_sgl64) { +iov_pa = ldq_phys(pa); +} else { +iov_pa = ldl_phys(pa); These load data from memory in target endianness. Are you sure that's what you want? I'd

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Paolo Bonzini
On 07/05/2011 03:38 PM, Alexander Graf wrote: >> >> +if (is_sgl64) { >> +iov_pa = ldq_phys(pa); >> +} else { >> +iov_pa = ldl_phys(pa); > > These load data from memory in target endianness. Are you sure that's > what you want? I'd expect this to be defined

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Signed-off-by: Hannes Reinecke --- Makefile.objs |1 + default-configs/pci.mak |1 + hw/megasas.c| 1950

Re: [Qemu-devel] [PATCH 5/5] megasas: LSI Megaraid SAS emulation

2011-07-05 Thread Alexander Graf
On 07/05/2011 01:03 PM, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. Nice, so it does work for me this time :). Tested-by: Alexander Graf Alex