Re: [Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 16:54, Andrew Jones drjo...@redhat.com wrote: On Tue, Mar 10, 2015 at 03:57:27PM +, Peter Maydell wrote: On 12 February 2015 at 17:08, Andrew Jones drjo...@redhat.com wrote: Actually, I should point out that this isn't just a cleanup, but also a fix. See below. The

Re: [Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-03-10 Thread Andrew Jones
On Tue, Mar 10, 2015 at 05:03:48PM +, Peter Maydell wrote: On 10 March 2015 at 16:54, Andrew Jones drjo...@redhat.com wrote: On Tue, Mar 10, 2015 at 03:57:27PM +, Peter Maydell wrote: On 12 February 2015 at 17:08, Andrew Jones drjo...@redhat.com wrote: Actually, I should point out

Re: [Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-03-10 Thread Andrew Jones
On Tue, Mar 10, 2015 at 03:57:27PM +, Peter Maydell wrote: On 12 February 2015 at 17:08, Andrew Jones drjo...@redhat.com wrote: On Thu, Feb 12, 2015 at 04:05:07PM +0100, Andrew Jones wrote: Now that we have get_S1prot, we can apply it to get_phys_addr_v6 for a minor code cleanup. I

Re: [Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-03-10 Thread Peter Maydell
On 12 February 2015 at 17:08, Andrew Jones drjo...@redhat.com wrote: On Thu, Feb 12, 2015 at 04:05:07PM +0100, Andrew Jones wrote: Now that we have get_S1prot, we can apply it to get_phys_addr_v6 for a minor code cleanup. I think this is a bad idea -- better to keep the long and short

[Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-02-12 Thread Andrew Jones
Now that we have get_S1prot, we can apply it to get_phys_addr_v6 for a minor code cleanup. Signed-off-by: Andrew Jones drjo...@redhat.com --- target-arm/helper.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/target-arm/helper.c

Re: [Qemu-devel] [PATCH 5/5] target-arm: apply get_S1prot to get_phys_addr_v6

2015-02-12 Thread Andrew Jones
On Thu, Feb 12, 2015 at 04:05:07PM +0100, Andrew Jones wrote: Now that we have get_S1prot, we can apply it to get_phys_addr_v6 for a minor code cleanup. Actually, I should point out that this isn't just a cleanup, but also a fix. See below. Signed-off-by: Andrew Jones drjo...@redhat.com