Re: [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after"

2017-09-14 Thread Richard Henderson
On 09/14/2017 08:20 AM, Lluís Vilanova wrote: >> I don't understand why you wouldn't just modify tcg_gen_goto_tb and >> tcg_gen_exit_tb instead. > > I prefer to keep all generic translation-related tracing on a single file, > where > it is easier to reason about. My point here was more about the

Re: [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after"

2017-09-14 Thread Lluís Vilanova
Richard Henderson writes: > On 09/10/2017 09:31 AM, Lluís Vilanova wrote: >> +void translator__gen_goto_tb(TCGContext *ctx) >> +{ >> +if (ctx->disas.in_guest_code && >> +(TRACE_GUEST_BBL_AFTER_ENABLED)) { >> +if (ctx->disas.inline_label == NULL) { >> +ctx->disas.inl

Re: [Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after"

2017-09-13 Thread Richard Henderson
On 09/10/2017 09:31 AM, Lluís Vilanova wrote: > +void translator__gen_goto_tb(TCGContext *ctx) > +{ > +if (ctx->disas.in_guest_code && > +(TRACE_GUEST_BBL_AFTER_ENABLED)) { > +if (ctx->disas.inline_label == NULL) { > +ctx->disas.inline_label = gen_new_inline_label();

[Qemu-devel] [PATCH 5/7] trace: Add event "guest_bbl_after"

2017-09-10 Thread Lluís Vilanova
Need to use "TCG inlining" to avoid showing a trace entry for each exit point (up to two per BBL). Signed-off-by: Lluís Vilanova --- accel/tcg/translator.c| 54 + include/exec/translator.h | 22 ++ tcg/tcg-op.c |