[Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future), so we need to check if .acb is NULL against bdrv_aio_cancel() to avoid segfault. Cc: Eric Blake ebl...@redhat.com Cc: Benoit Canet ben...@irqsave.net Cc: Kevin Wolf

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future) I have trouble understanding this part of the commit message could you try to clarify it ? , so we need

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one running aio (possible other cases that has less number than num_children in the future) I have trouble understanding this part

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Benoît Canet
The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote : On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one running aio (possible other cases that has less number than

Re: [Qemu-devel] [PATCH 5/8] quorum: fix quorum_aio_cancel()

2014-09-01 Thread Liu Yuan
On Mon, Sep 01, 2014 at 11:32:04AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 17:26:09 (+0800), Liu Yuan wrote : On Mon, Sep 01, 2014 at 10:35:27AM +0200, Benoît Canet wrote: The Monday 01 Sep 2014 à 15:43:11 (+0800), Liu Yuan wrote : For a fifo read pattern, we only have one